Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it #5216

Merged
1 commit merged into from Aug 30, 2015

Commits on Jul 16, 2015

  1. ceph.spec.in: python-argparse only in Python 2.6

    argparse is a widely-used Python module for parsing command-line arguments.
    Ceph makes heavy use of Python scripts, both in the build environment and on
    cluster nodes and clients.
    
    Until Python 2.6, argparse was distributed separately from Python proper.
    As of 2.7 it is part of the Python standard library.
    
    Although the python package in a given distro may or may not Provide:
    python-argparse, this cannot be relied upon.
    
    Therefore, this commit puts appropriate conditionals around Requires:
    python-argparse and BuildRequires: python-argparse. It does so for Red
    Hat/CentOS and SUSE only, because the last Fedora version with Python 2.6
    was Fedora 13, which is EOL.
    
    argparse is required by both the ceph and ceph-common packages, but since ceph
    requires ceph-common, the argparse Requires and BuildRequires need only appear
    once, under ceph-common.
    
    http://tracker.ceph.com/issues/12034 Fixes: ceph#12034
    
    Signed-off-by: Nathan Cutler <ncutler@suse.com>
    (cherry picked from commit 23171c9)
    smithfarm committed Jul 16, 2015
    Copy the full SHA
    8b576bd View commit details
    Browse the repository at this point in the history