Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: mds: do not send split_realms for CEPH_SNAP_OP_UPDATE msg #52848

Merged
merged 1 commit into from Aug 17, 2023
Merged

pacific: mds: do not send split_realms for CEPH_SNAP_OP_UPDATE msg #52848

merged 1 commit into from Aug 17, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Aug 7, 2023

backport tracker: https://tracker.ceph.com/issues/62193

backport of #51536
parent tracker: https://tracker.ceph.com/issues/61217

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz requested a review from a team August 7, 2023 04:21
@github-actions github-actions bot added the cephfs Ceph File System label Aug 7, 2023
@github-actions github-actions bot added this to the pacific milestone Aug 7, 2023
@lxbsz
mds: do not send split_realms for CEPH_SNAP_OP_UPDATE msg
67d095e 
The clients won't care about the split_realms and the kclient will
treat this as a corrupted snaptrace.

Fixes commit 93e7267 ("mds: send snap
	related messages centrally during mds recovery")
Fixes: https://tracker.ceph.com/issues/61217
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 3be9c97)

Conflicts:
 - Misses a dependent commit 7a4c509
@pdvian
Copy link

pdvian commented Aug 16, 2023

Rados approved: https://tracker.ceph.com/projects/rados/wiki/PACIFIC#httpstrellocomcONHeA3yz1823-wip-yuri8-testing-2023-08-11-0834-pacific

batrick
batrick approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Pacific#2023-August-11

@yuriw yuriw merged commit 910cf79 into ceph:pacific Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa pacific-batch-1 wip-yuri8-testing
Projects
None yet
Milestone
pacific
5 participants
@lxbsz @pdvian @batrick @vshankar @yuriw