suites: qa tasks with crush rules #53308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athanatos
requested changes
Sep 6, 2023
| 'set_choose_tries 100', | ||
| 'take default class hdd', | ||
| 'choose indep 4 type host', | ||
| 'chooseleaf indep 8 type osd', |
There was a problem hiding this comment.
Use choose rather than chooseleaf here due to https://tracker.ceph.com/issues/62213
There was a problem hiding this comment.
I'm not sure why this one needs 4 hosts, 8 osds per host. 2+2 should probably be a normal host chooseleaf rule, right?
There was a problem hiding this comment.
isn't it supposed to be 4 host 1 osd? so it will simulate full host shutdown?
There was a problem hiding this comment.
Right, so step chooseleaf indep 4 type host
There was a problem hiding this comment.
Ah,
'choose indep 4 type host',
'choose indep 1 type osd',
is almost correct, but you should use step chooseleaf indep 4 type host instead. Using two choose steps instead of a single chooseleaf step actually has different behavior once OSDs get marked out.
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
from
c90f6e5
to
f78ba83
Compare
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
9 times, most recently
from
364859e
to
31ba9f3
Compare
|
@athanatos @neha-ojha I added some code to thrash hosts, so the thrasher will be able to thrash the entire osds under one host |
athanatos
approved these changes
Sep 11, 2023
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
2 times, most recently
from
62ac56d
to
65c864f
Compare
|
Hey @NitzanMordhai, QA caught this failure: You can see more examples on this link: You can re-add the "needs-qa" label when it's ready for a retest! |
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
from
65c864f
to
1b10309
Compare
|
jenkins test make check |
|
@NitzanMordhai there are a few suspect jobs in the latest teuthology run as analyzed by @ronen-fr :
And two more with slightly different Tracebacks but similar problems:
These failures don't happen deterministically, so it might be worth running several of these "workloads/ec-rados-plugin=xxx} " tests multiple times to ensure they're passing. |
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
3 times, most recently
from
4f274e1
to
d536f03
Compare
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
3 times, most recently
from
646c2cd
to
2262a0e
Compare
|
I made some more changes to the thrasher, we had some issues with 4 hosts thrashing. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Adding new yaml entry to handle create of crush profile before creating new pool, will be skipped if no crush profile name was set. Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
Extra un needed checks and sets for filestore in suites setup need to be removed. Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
To simulate real world maintanace, we will usualy shut down hosts and not just osd the following commit will add host thrasher option to Thraser, when thrash_hosts is True we won't thrash osds one by one, we will choose entire host and thrash all the osds under that host. Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
NitzanMordhai
force-pushed
the
wip-nitzan-qa-tasks-with-crush-rules
branch
from
2262a0e
to
190a761
Compare
|
Looks like this one was merged a little early before a second round of QA could be reviewed. @NitzanMordhai can you take a look at https://tracker.ceph.com/issues/65517? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle EC profiles with crush rules of 2+2 and 8+6 on few hosts:
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows