quincy: mds/MDSRank: Add set_history_slow_op_size_and_threshold for op_tracker #53358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
void OpHistory::_insert_delayed(const utime_t& now, TrackedOpRef op)
{
...
double opduration = op->get_duration();
...
if (opduration >= history_slow_op_threshold.load()) {
slow_op.insert(make_pair(op->get_initiated(), op));
logger->inc(l_trackedop_slow_op_count);
}
...
}
mds op_tracker have no set slow op threshold, and history_slow_op_threshold default
value is 0, cause to mds have slow op alway.
Fixes: https://tracker.ceph.com/issues/61749
Signed-off-by: Yite Gu <yitegu0@gmail.com>
(cherry picked from commit 9b88a47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/61992
backport of #52081
parent tracker: https://tracker.ceph.com/issues/61749
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh