Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: mds/MDSRank: Add set_history_slow_op_size_and_threshold for op_tracker #53358

Merged
merged 1 commit into from
Jan 23, 2024
Merged

quincy: mds/MDSRank: Add set_history_slow_op_size_and_threshold for op_tracker #53358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/common/options/mds.yaml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,24 @@ options:
services:
- mds
with_legacy: true
# Max number of slow ops to track
- name: mds_op_history_slow_op_size
type: uint
level: advanced
desc: maximum size for list of historical slow operations
default: 20
services:
- mds
with_legacy: true
# Track the op if over this threshold
- name: mds_op_history_slow_op_threshold
type: uint
level: advanced
desc: track the op if over this threshold
default: 10
services:
- mds
with_legacy: true
# how many seconds old makes an op complaint-worthy
- name: mds_op_complaint_time
type: float
Expand Down
5 changes: 5 additions & 0 deletions src/mds/MDSRank.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,8 @@ MDSRank::MDSRank(
cct->_conf->mds_op_log_threshold);
op_tracker.set_history_size_and_duration(cct->_conf->mds_op_history_size,
cct->_conf->mds_op_history_duration);
op_tracker.set_history_slow_op_size_and_threshold(cct->_conf->mds_op_history_slow_op_size,
cct->_conf->mds_op_history_slow_op_threshold);

schedule_update_timer_task();
}
Expand Down Expand Up @@ -3795,6 +3797,9 @@ void MDSRankDispatcher::handle_conf_change(const ConfigProxy& conf, const std::s
if (changed.count("mds_op_history_size") || changed.count("mds_op_history_duration")) {
op_tracker.set_history_size_and_duration(conf->mds_op_history_size, conf->mds_op_history_duration);
}
if (changed.count("mds_op_history_slow_op_size") || changed.count("mds_op_history_slow_op_threshold")) {
op_tracker.set_history_slow_op_size_and_threshold(conf->mds_op_history_slow_op_size, conf->mds_op_history_slow_op_threshold);
}
if (changed.count("mds_enable_op_tracker")) {
op_tracker.set_tracking(conf->mds_enable_op_tracker);
}
Expand Down