Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: client: always refresh mds feature bits on session open #54146

Merged
merged 1 commit into from Oct 30, 2023
Merged

reef: client: always refresh mds feature bits on session open #54146

merged 1 commit into from Oct 30, 2023

Conversation

vshankar
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/63282

backport of #54030
parent tracker: https://tracker.ceph.com/issues/63188

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@vshankar vshankar added this to the reef milestone Oct 23, 2023
@vshankar vshankar added the cephfs Ceph File System label Oct 23, 2023
@vshankar vshankar requested a review from a team October 23, 2023 08:06
@dparmar18
Copy link
Contributor

dparmar18 commented Oct 23, 2023 •
edited

jenkins job failing due to:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:2423:7: error: use of undeclared identifier 'cap_auths'; did you mean 'cap_hits'?
      cap_auths = std::move(m->cap_auths);
      ^~~~~~~~~
      cap_hits
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1612:12: note: 'cap_hits' declared here
  uint64_t cap_hits = 0;
           ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:2423:32: error: no member named 'cap_auths' in 'MClientSession'
      cap_auths = std::move(m->cap_auths);
                            ~~~^
2 errors generated.

points to code 01a9398

lxbsz
lxbsz reviewed Oct 23, 2023
View reviewed changes
src/client/Client.cc Outdated Show resolved Hide resolved
@vshankar
client: always refresh mds feature bits on session open
997b917 
Fixes: http://tracker.ceph.com/issues/63188
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 167fdd2)

 Conflicts:
	src/client/Client.cc

Minor conflict due to presence of

        cap_auths = std::move(m->cap_auths);
@yuriw yuriw merged commit 4b8f23e into ceph:reef Oct 30, 2023
10 checks passed
@vshankar vshankar mentioned this pull request Oct 31, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxbsz lxbsz lxbsz approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa wip-yuri6-testing
Projects
None yet
Milestone
reef
4 participants
@vshankar @dparmar18 @lxbsz @yuriw