pacific: ceph-volume: fixes fallback to stat in is_device and is_partition #54709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0ste
force-pushed
the
wip-63677-pacific
branch
2 times, most recently
from
54ad57c
to
830ad44
Compare
pereman2
requested changes
Jan 18, 2024
k0ste
force-pushed
the
wip-63677-pacific
branch
from
830ad44
to
e684a47
Compare
os.stat (or lstat) cannot distinguish a block device from a partition. Fixes: https://tracker.ceph.com/issues/58812 Signed-off-by: Teoman ONAY <tonay@ibm.com> (cherry picked from commit 52ca4a6)
This makes ceph-volume report partitions in inventory. A partition is a valid device for `ceph-volume lvm prepare` so we should report them in inventory (when using `--list-all` parameter). Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com> (cherry picked from commit 00ba00f) Conflicts: - file: src/ceph-volume/ceph_volume/util/device.py comment: pacific don't have --list-all, remove from init - src/ceph-volume/ceph_volume/util/disk.py comment: manually resolve conflict in block_types[]
k0ste
force-pushed
the
wip-63677-pacific
branch
from
e684a47
to
85670b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63677
backport of #53798
parent tracker: https://tracker.ceph.com/issues/58812
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh