Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: ceph-volume: fixes fallback to stat in is_device and is_partition #54709

Merged
merged 2 commits into from Jan 24, 2024
Merged

pacific: ceph-volume: fixes fallback to stat in is_device and is_partition #54709

merged 2 commits into from Jan 24, 2024

Commits on Jan 23, 2024

  1. ceph-volume: fixes fallback to stat in is_device and is_partition 

    os.stat (or lstat) cannot distinguish a block device from
a partition.

Fixes: https://tracker.ceph.com/issues/58812

Signed-off-by: Teoman ONAY <tonay@ibm.com>
(cherry picked from commit 52ca4a6)
    @asm0deuz @k0ste
    asm0deuz authored and k0ste committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6cada60 View commit details
    Browse the repository at this point in the history

  2. ceph-volume: support partitions in inventory 

    This makes ceph-volume report partitions in inventory.
A partition is a valid device for `ceph-volume lvm prepare`
so we should report them in inventory (when using `--list-all`
parameter).

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 00ba00f)

Conflicts:
  - file: src/ceph-volume/ceph_volume/util/device.py
    comment: pacific don't have --list-all, remove from init
  - src/ceph-volume/ceph_volume/util/disk.py
    comment: manually resolve conflict in block_types[]
    @guits @k0ste
    guits authored and k0ste committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    85670b4 View commit details
    Browse the repository at this point in the history