Correct handling of supplementary groups in ceph-fuse (Bug 12617) #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukernel
added a commit
that referenced
this pull request
Aug 12, 2015
Correct handling of supplementary groups in ceph-fuse (Bug 12617)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes Bug 12617 by using the getgrouplist function to retrieve a list of all supplementary groups.
The function should be compatible with PAM (works in a sssd based setup for the submitter) and shoud be reentrant. The also used function getpwuid might needs to be replaced with getpwuid_r if necessary.
The PR might be merged with #5480, which skipped permission checks if already done in the kernel itself.