squid: rgw: compatibility issues on BucketPublicAccessBlock #56043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the AWS doc (https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetPublicAccessBlock.html) it needs to be PublicAccessBlockConfiguration. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit db74c10)
s3GetBucketPublicAccessBlock needs to be checked for RGWGetBucketPublicAccessBlock operation. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 54bc5eb)
Return 404 when there is no public access block on the bucket. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 146d4d9)
According to AWS doc (https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeletePublicAccessBlock.html#API_DeletePublicAccessBlock_ResponseSyntax) 204 shall be returned on delete request. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 48a4549)
|
qa needs to include ceph/s3-tests#551 |
dang
approved these changes
Mar 7, 2024
|
jenkins test this please |
|
|
jenkins test make check |
|
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64795
backport of #55652
parent tracker: https://tracker.ceph.com/issues/64492
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh