rgw: compatibility issues on BucketPublicAccessBlock #55652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do any s3test cases need to be updated? it would be nice to add test coverage for these changed behaviors
you're sure that aws returns this specific "NoSuchPublicAccessBlockConfiguration" error for buckets that haven't set one? i didn't see that listed in https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html |
Yes, it was confusing for me as well but seems in practice it is. Also here is another reference to it: boto/boto3#3627 I'll add s3 tests for the coverage. |
clwluvw
added a commit
to clwluvw/s3-tests
that referenced
this pull request
Feb 19, 2024
Make sure NoSuchPublicAccessBlockConfiguration is returned when no public block is configured on bucket: Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
added a commit
to clwluvw/s3-tests
that referenced
this pull request
Feb 19, 2024
Make sure 403 is returned when access is denied via s3:GetBucketPublicAccessBlock action on GetBucketPublicAccessBlock Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
@cbodley Please take a look at this: ceph/s3-tests#551 |
clwluvw
added a commit
to clwluvw/s3-tests
that referenced
this pull request
Feb 20, 2024
Make sure NoSuchPublicAccessBlockConfiguration is returned when no public block is configured on bucket: Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
added a commit
to clwluvw/s3-tests
that referenced
this pull request
Feb 20, 2024
Make sure 403 is returned when access is denied via s3:GetBucketPublicAccessBlock action on GetBucketPublicAccessBlock Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
From the AWS doc (https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetPublicAccessBlock.html) it needs to be PublicAccessBlockConfiguration. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
s3GetBucketPublicAccessBlock needs to be checked for RGWGetBucketPublicAccessBlock operation. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Return 404 when there is no public access block on the bucket. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
According to AWS doc (https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeletePublicAccessBlock.html#API_DeletePublicAccessBlock_ResponseSyntax) 204 shall be returned on delete request. Fixes: https://tracker.ceph.com/issues/64492 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
force-pushed
the
rgw-blockaccesspublic
branch
from
26aa2c8
to
48a4549
Compare
cbodley
approved these changes
Feb 22, 2024
|
jenkins test this please |
cbodley
pushed a commit
to ceph/s3-tests
that referenced
this pull request
Mar 8, 2024
Make sure NoSuchPublicAccessBlockConfiguration is returned when no public block is configured on bucket: Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 3056e6d)
cbodley
pushed a commit
to ceph/s3-tests
that referenced
this pull request
Mar 8, 2024
Make sure 403 is returned when access is denied via s3:GetBucketPublicAccessBlock action on GetBucketPublicAccessBlock Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 3af4231)
cbodley
pushed a commit
to ceph/s3-tests
that referenced
this pull request
Mar 8, 2024
Make sure NoSuchPublicAccessBlockConfiguration is returned when no public block is configured on bucket: Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 3056e6d)
cbodley
pushed a commit
to ceph/s3-tests
that referenced
this pull request
Mar 8, 2024
Make sure 403 is returned when access is denied via s3:GetBucketPublicAccessBlock action on GetBucketPublicAccessBlock Refs: ceph/ceph#55652 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 3af4231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/64492