rgw_file: fix mv/rename cases broken by zipper integration #56220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems. First, leaf object names must be expressed as fully-qualified to the bucket as input to the copy-object step. Second, handle s->object in the same step indicates the being-created destination object of the copy, this was correct in the original zipper change but broken later. * add a rename/mv unit test Tests for the following cases added: 1. move between two sub-directory paths in a single bucket 2. move between two names at the top level of a single bucket 3. move between sub-directory paths in different buckets (cross-bucket rename) Fixes: https://tracker.ceph.com/issues/64950 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
dang
approved these changes
Mar 15, 2024
|
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems. First, leaf object names must be expressed as fully-qualified to the bucket as input to the copy-object step. Second, handle s->object in the same step indicates the being-created destination object of the copy, this was correct in the original zipper change but broken later.
Tests for the following cases added:
Fixes: https://tracker.ceph.com/issues/64950
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e