squid: rgw_file: fix mv/rename cases broken by zipper integration #56345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems. First, leaf object names must be expressed as fully-qualified to the bucket as input to the copy-object step. Second, handle s->object in the same step indicates the being-created destination object of the copy, this was correct in the original zipper change but broken later. * add a rename/mv unit test Tests for the following cases added: 1. move between two sub-directory paths in a single bucket 2. move between two names at the top level of a single bucket 3. move between sub-directory paths in different buckets (cross-bucket rename) Fixes: https://tracker.ceph.com/issues/64950 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit f11cdb1)
dang
approved these changes
Mar 21, 2024
|
jenkins test this please |
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65009
backport of #56220
parent tracker: https://tracker.ceph.com/issues/64950
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh