Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: testGetContentType and testHead failed #5718

Merged
merged 6 commits into from Oct 12, 2015
Merged

rgw: testGetContentType and testHead failed #5718

merged 6 commits into from Oct 12, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2015

@ghost ghost self-assigned this Aug 30, 2015
@ghost ghost added this to the hammer milestone Aug 30, 2015
@ghost ghost added bug-fix rgw labels Aug 30, 2015
@ghost ghost mentioned this pull request Aug 30, 2015
Closed
ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
c86a052 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/7342/

ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
c120d8c 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
7a2fb81 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 31, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
1beb05e 
Reviewed-by: Loic Dachary <ldachary@redhat.com>

Conflicts:
	src/rgw/rgw_rest.cc
ghost pushed a commit that referenced this pull request Aug 31, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
3b87202 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title testGetContentType and testHead failed DNM: testGetContentType and testHead failed Aug 31, 2015
@ghost
Copy link
Author

ghost commented Sep 1, 2015

It fails consistently with:

filter="rgw/multifs/{overrides.yaml clusters/fixed-2.yaml frontend/civetweb.yaml fs/xfs.yaml rgw_pool_type/replicated.yaml tasks/rgw_swift.yaml}" 
./virtualenv/bin/teuthology-suite --priority 101 --suite rgw --filter="$filter" --suite-branch hammer --distro ubuntu --email loic@dachary.org --ceph hammer-backports-loic --machine-type plana,burnupi,mira

where hammer-backports-loic is a a branch with hammer and only this pull request on top of it. Here is an example of a failure : http://pulpito.ceph.com/loic-2015-09-01_00:12:35-rgw-hammer-backports-loic---basic-multi. The same job run with the hammer suite succeeds: this is not an environmental problem.

@ghost
Copy link
Author

ghost commented Sep 1, 2015

@oritwas I'm afraid I'm going to need your expertise on this one. I don't know enough of rgw to figure out why it fails.

@oritwas
Copy link
Member

oritwas commented Sep 1, 2015

This is strange. I will look at it

@ghost
Copy link
Author

ghost commented Sep 1, 2015

@oritwas thanks ! Note that it's not blocking anything. I got confused at first because there were many pull request in the same branch. Now that it's isolated and easy to reproduce, we'll just set it aside.

@oritwas
Copy link
Member

oritwas commented Sep 2, 2015

@dachary , it apears we missed two commits, see https://github.com/ceph/ceph/tree/wip-swift-backports-hammer

@ghost
Copy link
Author

ghost commented Sep 2, 2015

@oritwas picked the commits, many thanks ! I also created http://tracker.ceph.com/issues/12918 to link 4b7dbf6 to its original issue http://tracker.ceph.com/issues/12158. I presume 4c5ac21 is a commit that belongs to http://tracker.ceph.com/issues/12157#note-7.

@loic-bot
Copy link

loic-bot commented Sep 3, 2015

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/7439/

oritwas and others added 6 commits September 3, 2015 13:28
@oritwas @ldachary
rgw: shouldn't return content-type: application/xml if content length…
b5420d6 
… is 0

Fixed: #11091

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 5cc92bb)
@oritwas @ldachary
rgw: force content-type header for swift account responses without body
143cfc3 
This regression was introduced in commit 4cfeca0

Fixes: #11438

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 009664e)
@rzarzynski @ldachary
rgw: enforce Content-Type in Swift responses.
b8aafbc 
Swift sends Content-Type HTTP header even if the response
doesn't contain body. We have this behaviour implemented
until applying some changes in end_header() function.
Unfortunately, lack of Content-Type causes early exits in
many Tempest's tests for Swift API verification.

Fixes: #12157
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit 106aeba)
@oritwas @ldachary
rgw: we should not overide Swift sent content type
5d57b63 
Fixes: #12363
backport: hammer

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 423cf13)
@oritwas @ldachary
rgw: force content_type for swift bucket stats request
2e54245 
Fixes: 12095

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit da259e4)
@rzarzynski @ldachary
rgw: send Content-Length in response for GET on Swift account.
e80bd0a 
Fixes: #12158
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit 5f47b11)
Conflicts:
	src/rgw/rgw_rest_swift.cc
@loic-bot
Copy link

loic-bot commented Sep 3, 2015

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/7467/

@ghost
Copy link
Author

ghost commented Sep 3, 2015 

filter="rgw/multifs/{overrides.yaml clusters/fixed-2.yaml frontend/civetweb.yaml fs/xfs.yaml rgw_pool_type/replicated.yaml tasks/rgw_swift.yaml}" 
./virtualenv/bin/teuthology-suite --priority 101 --suite rgw --filter="$filter" --suite-branch hammer --distro ubuntu --email loic@dachary.org --ceph wip-12859-hammer-loic --machine-type plana,burnupi,mira

@smithfarm smithfarm mentioned this pull request Sep 13, 2015
Merged
@ghost ghost changed the title DNM: testGetContentType and testHead failed testGetContentType and testHead failed Sep 13, 2015
ghost pushed a commit that referenced this pull request Oct 2, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
a171163 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
c619643 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
30beb04 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
17228c2 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@smithfarm smithfarm mentioned this pull request Oct 5, 2015
Merged
ghost pushed a commit that referenced this pull request Oct 7, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
89ca93b 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Oct 7, 2015

@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-5 for details ).

ghost pushed a commit that referenced this pull request Oct 8, 2015
@ldachary
Merge pull request #5718: testGetContentType and testHead failed
494d864 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
yehudasa added a commit that referenced this pull request Oct 12, 2015
@yehudasa
Merge pull request #5718 from dachary/wip-12859-hammer
dd64c78 
testGetContentType and testHead failed
@yehudasa yehudasa merged commit dd64c78 into ceph:hammer Oct 12, 2015
@ghost ghost changed the title testGetContentType and testHead failed rgw: testGetContentType and testHead failed Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix rgw
Projects
None yet
Milestone
hammer
4 participants
@loic-bot @oritwas @yehudasa @rzarzynski