Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid: doc/cephadm: Squid default images procedure #57225

Conversation

zdover23
Copy link
Contributor

@zdover23 zdover23 commented May 2, 2024

Address Adam King's request for version-specific
cephadm-container-image-retrieval procedures, which he requested here: #57208 (comment)

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@zdover23 zdover23 requested a review from a team as a code owner May 2, 2024 08:39
@zdover23 zdover23 force-pushed the wip-doc-2024-05-02-cephadm-services-monitoring-squid branch from 437b842 to 86b1d28 Compare May 2, 2024 08:41
Copy link
Contributor

@adk3798 adk3798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor points, mostly about which releases are zips. Are we also going to have a similar update for reef and main?

doc/cephadm/services/monitoring.rst Outdated Show resolved Hide resolved
doc/cephadm/services/monitoring.rst Outdated Show resolved Hide resolved
doc/cephadm/services/monitoring.rst Outdated Show resolved Hide resolved
doc/cephadm/services/monitoring.rst Outdated Show resolved Hide resolved
@zdover23
Copy link
Contributor Author

zdover23 commented May 2, 2024

Some minor points, mostly about which releases are zips. Are we also going to have a similar update for reef and main?

I'm working on them now. They will be done by the end of the North American day.

@adk3798
Copy link
Contributor

adk3798 commented May 2, 2024

Some minor points, mostly about which releases are zips. Are we also going to have a similar update for reef and main?

I'm working on them now. They will be done by the end of the North American day.

Thanks

Address Adam King's request for version-specific
cephadm-container-image-retrieval procedures, which he requested here: ceph#57208 (comment)

Co-authored-by: Adam King <adking@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
@zdover23 zdover23 force-pushed the wip-doc-2024-05-02-cephadm-services-monitoring-squid branch from 86b1d28 to 58b5b54 Compare May 2, 2024 12:34
@zdover23 zdover23 requested a review from adk3798 May 2, 2024 12:37
zdover23 added a commit to zdover23/ceph that referenced this pull request May 2, 2024
Address Adam King's request for version-specific
cephadm-container-image-retrieval procedures, which he requested here:
ceph#57208 (comment)

See also ceph#57225, the Squid counterpart
to this Reef-targeted pull request.

Signed-off-by: Zac Dover <zac.dover@proton.me>

::

DEFAULT_IMAGE = 'quay.ceph.io/ceph-ci/ceph:main'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this is accurate to what would get outputted currently, but I'll need to adjust this to point to quay.ceph.io/ceph-ci/ceph:squid at some point. I'll make sure to adjust this line in the docs when that happens.

@zdover23 zdover23 merged commit e2bfab0 into ceph:squid May 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants