Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: recursive lock of md_config_t (0) #5759

Merged
1 commit merged into from Sep 7, 2015

Conversation

Projects
None yet
3 participants
@ghost
Copy link

ghost commented Sep 2, 2015

config: skip lockdep for intentionally recursive md_config_t lock
lockdep can't handle recursive locks, resulting in false positive
reports for certain set_val_or_die() calls, like via
md_config_t::parse_argv() passed "-m".

Fixes: #12614
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
(cherry picked from commit 4152269)

@ghost ghost self-assigned this Sep 2, 2015

@ghost ghost added this to the hammer milestone Sep 2, 2015

@ghost ghost added bug fix core labels Sep 2, 2015

ghost pushed a commit that referenced this pull request Sep 2, 2015

Merge pull request #5759: recursive lock of md_config_t (0)
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Sep 6, 2015

@liewegas this hammer backport passed a rados suite (see http://tracker.ceph.com/issues/12701#note-62 for the details). Do you think it is ready to be merged ?

@ghost ghost assigned liewegas and unassigned ghost Sep 6, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Sep 7, 2015

👍

ghost pushed a commit that referenced this pull request Sep 7, 2015

Loic Dachary
Merge pull request #5759 from dachary/wip-12841-hammer
recursive lock of md_config_t (0)

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit 7614bf7 into ceph:hammer Sep 7, 2015

@ghost ghost changed the title recursive lock of md_config_t (0) common: recursive lock of md_config_t (0) Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.