mon/PGMap: calc min_last_epoch_clean when decode #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov I'm not sure how the failure can be related with your change. ../qa/workunits/ceph-helpers.sh:800: objectstore_tool: ceph-objectstore-tool --data-path testdir/osd-scrub-repair/1 --journal-path testdir/osd-scrub-repair/1/journal SOMETHING remove remove 1:2/847441d7/SOMETHING/head common/Mutex.cc: In function 'void Mutex::Lock(bool)' thread 2b9bc3517700 time 2015-09-16 08:43:02.421793 common/Mutex.cc: 105: FAILED assert(r == 0) ceph version 9.0.3-1679-g1f22687 (1f226872b371a0d4f8376478af26a31a80fd8a76) 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x8b) [0x2b9bbbc5822b] 2: (Mutex::Lock(bool)+0x19c) [0x2b9bbbc1832c] 3: (FileStore::_journaled_ahead(FileStore::OpSequencer*, FileStore::Op*, Context*)+0x1ea) [0x2b9bbba7feca] 4: (Context::complete(int)+0x9) [0x2b9bbb7ed969] 5: (Finisher::finisher_thread_entry()+0x158) [0x2b9bbbba1518] 6: (()+0x8182) [0x2b9bbef2d182] 7: (clone()+0x6d) [0x2b9bc085247d] NOTE: a copy of the executable, or `objdump -rdS ` is needed to interpret this. terminate called after throwing an instance of 'ceph::FailedAssertion' *** Caught signal (Aborted) ** but it's the first time I'm seing this. Would you mind re-pushing to trigger another run and confirm it's a false negative ? |
tchaikov
force-pushed
the
wip-13112-infernalis
branch
from
df31baf
to
9b56efb
Compare
|
@dachary rebased and repushed. |
|
@tchaikov thanks, filed http://tracker.ceph.com/issues/13113 to track that should it happen again |
|
sigh.. annoying we missed this. Reviewed-by: |
|
Can we adjust the unit test to catch this case? |
will do. |
Fixes: ceph#13112 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-13112-infernalis
branch
from
9b56efb
to
d0ac68b
Compare
|
@liewegas test added |
liewegas
added a commit
that referenced
this pull request
Sep 20, 2015
mon/PGMap: calc min_last_epoch_clean when decode Reviewed-by: Sage Weil <sage@redhat.com>
|
@tchaikov we shoudl backport this to hammer, yeah? |
|
@liewegas yes. http://tracker.ceph.com/issues/13112 is now pending backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in 208959a
http://tracker.ceph.com/issues/13112 Fixes: #13112,
Signed-off-by: Kefu Chai kchai@redhat.com