Wip 6332 #606
Merged
Wip 6332 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current LOOKUPSNAP code path was dereferencing mdr->dn[0] and getting SEGV. Instead, set the do_lookup arg to false for getattr so that we do not try to dereference this; for snaps it will always be NULL as we are constructing a fake namespace for the .snap directory. (This happens in the path_traverse, the result of which is to set snapid--without any real dentry). With this fix, snaptest-0.sh passes. Signed-off-by: Sage Weil <sage@inktank.com> Reviewed-by: Greg Farnum <greg@inktank.com>
This way users can't put snapshots on their clusters unless they explicitly ask for them and have seen a warning message. We take a bit of the MDSMap flags in order to do so. The only thing a little weird here is that anybody who upgrades to this patch who already has snapshots will hit the EPERM and have to go through the warning, but it doesn't impact existing snapshots at all so they should be good. To go along with this, we add "ever_allowed_snaps" and "explicitly_allowed_snaps" members to the MDSMap, which are default to false and are set to true when allow_new_snaps is set. Old maps decoded with new code default to true and false, respectively, so we can tell. Fixes: #6332 Signed-off-by: Greg Farnum <greg@inktank.com> Signed-off-by: Loic Dachary <loic@dachary.org>
Test that it works in snaptest-0.sh, and set the flag in all the snap workunits so they continue to function. Signed-off-by: Greg Farnum <greg@inktank.com> Reviewed-by: Loic Dachary <loic@dachary.org>
By default options are required, and that leads to the Ceph CLI making users add this to their commands before even submitting it to the monitor. We want them to see and think about the messages generated by the monitor! Signed-off-by: Greg Farnum <greg@inktank.com> Signed-off-by: Loic Dachary <loic@dachary.org>
gregsfortytwo
added a commit
that referenced
this pull request
Sep 26, 2013
Reviewed-by: Sage Weil <sage@inktank.com>
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 18, 2016
tasks/ceph_fuse.py: virtual machines need flexible mount timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch does two things: