Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip 6332 #606

Merged
merged 4 commits into from Sep 26, 2013
Merged

Wip 6332 #606

merged 4 commits into from Sep 26, 2013

Commits on Sep 26, 2013

  1. mds/Server: fix LOOKUPSNAP 

    The current LOOKUPSNAP code path was dereferencing mdr->dn[0] and getting
SEGV.  Instead, set the do_lookup arg to false for getattr so that we do
not try to dereference this; for snaps it will always be NULL as we are
constructing a fake namespace for the .snap directory.  (This happens in
the path_traverse, the result of which is to set snapid--without any real
dentry).

With this fix, snaptest-0.sh passes.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
    @gregsfortytwo
    Sage Weil authored and gregsfortytwo committed Sep 26, 2013
    Configuration menu
    Copy the full SHA
    3cffff2 View commit details
    Browse the repository at this point in the history

  2. MDS: lock out snapshots until after a flag has been set in the MDSMap 

    This way users can't put snapshots on their clusters unless they explicitly
ask for them and have seen a warning message. We take a bit of the MDSMap
flags in order to do so. The only thing a little weird here is that anybody
who upgrades to this patch who already has snapshots will hit the EPERM
and have to go through the warning, but it doesn't impact existing snapshots
at all so they should be good.

To go along with this, we add "ever_allowed_snaps" and "explicitly_allowed_snaps"
members to the MDSMap, which are default to false and are set to true
when allow_new_snaps is set. Old maps decoded with new code default to true
and false, respectively, so we can tell.

Fixes: #6332

Signed-off-by: Greg Farnum <greg@inktank.com>
Signed-off-by: Loic Dachary <loic@dachary.org>
    @gregsfortytwo
    gregsfortytwo authored and Loic Dachary committed Sep 26, 2013
    Configuration menu
    Copy the full SHA
    9771b1d View commit details
    Browse the repository at this point in the history

  3. qa: update snaps workunits for allow_new_snaps flag 

    Test that it works in snaptest-0.sh, and set the flag in
all the snap workunits so they continue to function.

Signed-off-by: Greg Farnum <greg@inktank.com>
Reviewed-by: Loic Dachary <loic@dachary.org>
    @gregsfortytwo
    gregsfortytwo authored and Loic Dachary committed Sep 26, 2013
    Configuration menu
    Copy the full SHA
    ca97fae View commit details
    Browse the repository at this point in the history

  4. mon: don't list "--yes-i-really-mean-it" options as required 

    By default options are required, and that leads to the Ceph CLI making
users add this to their commands before even submitting it to the monitor. We
want them to see and think about the messages generated by the monitor!

Signed-off-by: Greg Farnum <greg@inktank.com>
Signed-off-by: Loic Dachary <loic@dachary.org>
    @gregsfortytwo
    gregsfortytwo authored and Loic Dachary committed Sep 26, 2013
    Configuration menu
    Copy the full SHA
    6b435f5 View commit details
    Browse the repository at this point in the history