librbd: new exclusive lock release journal event #7818

sahithi-rv · 2016-02-26T13:03:07Z

Signed-off-by: Sahithi R V sahithi.rv1@gmail.com

sahithi-rv · 2016-02-26T13:03:36Z

The event created is not yet fully functional.

dillaman · 2016-02-26T18:42:50Z

Can you put the tracker # in the commit message:

Fixes: #14414

dillaman · 2016-02-26T18:45:48Z

src/librbd/exclusive_lock/ReleaseRequest.cc

@@ -131,9 +132,31 @@ Context *ReleaseRequest<I>::handle_flush_notifies(int *ret_val) {

  assert(*ret_val == 0);
  send_close_journal();


Remove this line -- we need to append the event before closing the journal

dillaman · 2016-02-26T18:51:45Z

Also, please add a test case for this new event. See https://github.com/ceph/ceph/blob/master/src/test/librbd/journal/test_mock_Replay.cc#L454 for an example.

jdurgin · 2016-03-02T05:07:29Z

Looks like this needs rebasing after some recent merges. Could you put the "Fixes: #XYZ" on a separate line in the commit messages, like in: 5d41735 ? It helps keep the first line shorter as well

dillaman · 2016-03-07T19:45:00Z

src/librbd/exclusive_lock/ReleaseRequest.cc

@@ -129,23 +130,50 @@ Context *ReleaseRequest<I>::handle_flush_notifies(int *ret_val) {
  CephContext *cct = m_image_ctx.cct;
  ldout(cct, 10) << __func__ << dendl;

-  assert(*ret_val == 0);


Still a valuable assert statement

sahithi-rv · 2016-03-10T03:39:45Z

@dillaman can you please test it now?

dillaman · 2016-03-10T03:54:20Z

@sahithi-rv You can just check the github build status at the bottom of the PR. It says you need to rebase your PR to the current master branch.

dillaman · 2016-03-11T14:43:13Z

Getting closer -- the unit tests are crashing. You can repeat this locally by running "RBD_FEATURES=109 ./unittest_librbd" from the 'src' directory.

dillaman · 2016-03-11T14:43:51Z

src/librbd/journal/Types.h

@@ -253,6 +254,18 @@ struct FlattenEvent : public OpEventBase {
  using OpEventBase::dump;
 };

+struct ExclusiveLockReleaseEvent : public OpEventBase {


Don't need to inherit from OpEventBase -- this isn't a maintenance operation. As a result, you won't need an op_tid.

Then what do I do about encode, decode, dump member functions.

Implement them as empty methods just like UnknownEvent

dillaman · 2016-03-20T14:43:38Z

src/librbd/Journal.h

@@ -239,6 +240,7 @@ class Journal {
  };

  Journaler *m_journaler;
+  uint64_t m_tag_id;


This doesn't appear to be used -- perhaps pulled in from a bad rebase.

sahithi-rv · 2016-03-22T17:30:55Z

I do not get error when I run RBD_FEATURES=61 ./unittest_librbd , but i get segfault when I run run-rbd-unit-tests.sh . But I think both are doing pretty much the same thing?

dillaman · 2016-03-22T17:34:22Z

RBD_FEATURES=61 doesn't test any journaling-related functionality. run-rbd-unit-tests.sh runs unittest_librbd with several combinations for RBD_FEATURES -- including RBD_FEATURES=109 which enables support for journaling.

dillaman · 2016-03-22T18:01:04Z

Which RBD_FEATURES=x causes the crash?

sahithi-rv · 2016-03-22T18:02:25Z

x = 61 and x=109.
When I use m_image_ctx instead of m_journal ,x=61 or x=109 , donot throw errors but run-rbd-unit-tests throws segfault.

dillaman · 2016-03-22T18:04:50Z

Now I am confused since you said 109 doesn't have any issue.

sahithi-rv · 2016-03-22T18:07:01Z

Ok. sorry I have used m_image_ctx in ReleaseRequest first and tested. then I get not errors with running unittest_librbd with RBD_FEATURES= 61, 109. But i got Segfault when I run run-rbd-unit-tests and i found that $i = 61 and $i -109 give error.

sahithi-rv · 2016-03-22T18:08:11Z

When I use m_journal in ReleaseRequest.cc, and run RBD_FEATURES=61 ./unittest_librbd I get this error

sahithi-rv · 2016-03-22T18:42:45Z

Now I tried to free mock_journal in every test in test_mock_ExclusiveLock and test_mock_ReleaseRequest. This does not give me errors as shown above. But it still throws segfault.
Is there a way to debug segfault, here?

dillaman · 2016-03-22T18:52:39Z

RBD_FEATURES=109 libtool e gdb ./unittest_librbd

Fixes: ceph#14414 Signed-off-by: Sahithi R V <sahithi.rv1@gmail.com>

sahithi-rv · 2016-04-03T14:03:24Z

When I run RBD_FEATURES=109 ./unittest_librbd, the tests run successfully till "TestMockImageRefreshRequest.SuccessV2" , but is stuck at "TestMockImageRefreshRequest.SuccessSnapshotV2"

sahithi-rv · 2016-04-03T15:47:31Z

What does it mean append_lock_release_event(_) is not called? I get this error:

dillaman · 2016-04-04T18:40:47Z

@sahithi-rv It's hard for me to say since the code available on github doesn't match up with that error message. It appears like in your version of the code, for the "UnlockError" test, you had an expectation for "expect_append_lock_release_event", but it was never called before the lock was released.

Fixes: ceph#14414 Signed-off-by: Sahithi R V <sahithi.rv1@gmail.com>

dillaman · 2016-06-21T16:15:00Z

Closing this PR -- the Jewel version uses journal tag epochs to track the acquire/release of the exclusive lock.

dillaman added feature rbd labels Feb 26, 2016

dillaman changed the title ~~librbd: subtask #14414~~ librbd: new exclusive lock release journal event Feb 26, 2016

dillaman reviewed Feb 26, 2016
View reviewed changes

sahithi-rv force-pushed the 14414 branch from 1452187 to 1c7bf50 Compare February 27, 2016 07:22

sahithi-rv force-pushed the 14414 branch 4 times, most recently from 1ee95f9 to bf37151 Compare March 2, 2016 12:36

dillaman reviewed Mar 7, 2016
View reviewed changes

dillaman added this to the jewel milestone Mar 8, 2016

sahithi-rv force-pushed the 14414 branch 2 times, most recently from 0f7c52b to 8acb684 Compare March 9, 2016 20:52

sahithi-rv force-pushed the 14414 branch 2 times, most recently from 2d4e99c to 1d6e627 Compare March 11, 2016 08:59

dillaman reviewed Mar 11, 2016
View reviewed changes

sahithi-rv force-pushed the 14414 branch from 1d6e627 to a00b3b5 Compare March 11, 2016 16:48

dillaman reviewed Mar 20, 2016
View reviewed changes

sahithi-rv force-pushed the 14414 branch 4 times, most recently from 4fd59da to fe85425 Compare March 31, 2016 08:40

sahithi-rv added 3 commits April 3, 2016 16:40

librbd: create exclusive lock release event and append to journal

2022f8a

Fixes: ceph#14414 Signed-off-by: Sahithi R V <sahithi.rv1@gmail.com>

test/librbd/journal: added test case for exclusive lock release event

91a6f09

Fixes: ceph#14414 Signed-off-by: Sahithi R V <sahithi.rv1@gmail.com>

librbd/Journal: added append_lock_release_event member function

464bae0

Fixes: ceph#14414 Signed-off-by: Sahithi R V <sahithi.rv1@gmail.com>

sahithi-rv force-pushed the 14414 branch from fe85425 to f2226cd Compare April 3, 2016 15:31

test/librbd: added tests for append_lock_release_event

95757c5

Fixes: ceph#14414 Signed-off-by: Sahithi R V <sahithi.rv1@gmail.com>

sahithi-rv force-pushed the 14414 branch from f2226cd to 95757c5 Compare April 7, 2016 08:01

dillaman modified the milestones: kraken, jewel Apr 11, 2016

jdurgin removed this from the kraken milestone May 10, 2016

dillaman closed this Jun 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

librbd: new exclusive lock release journal event #7818

librbd: new exclusive lock release journal event #7818

sahithi-rv commented Feb 26, 2016

sahithi-rv commented Feb 26, 2016

dillaman commented Feb 26, 2016

dillaman Feb 26, 2016

dillaman commented Feb 26, 2016

jdurgin commented Mar 2, 2016

dillaman Mar 7, 2016

sahithi-rv commented Mar 10, 2016

dillaman commented Mar 10, 2016

dillaman commented Mar 11, 2016

dillaman Mar 11, 2016

sahithi-rv Mar 11, 2016

dillaman Mar 11, 2016

dillaman Mar 20, 2016

sahithi-rv commented Mar 22, 2016

dillaman commented Mar 22, 2016

dillaman commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

dillaman commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

dillaman commented Mar 22, 2016

sahithi-rv commented Apr 3, 2016

sahithi-rv commented Apr 3, 2016

dillaman commented Apr 4, 2016

dillaman commented Jun 21, 2016

		@@ -131,9 +132,31 @@ Context ReleaseRequest<I>::handle_flush_notifies(int ret_val) {

		assert(*ret_val == 0);
		send_close_journal();

librbd: new exclusive lock release journal event #7818

librbd: new exclusive lock release journal event #7818

Conversation

sahithi-rv commented Feb 26, 2016

sahithi-rv commented Feb 26, 2016

dillaman commented Feb 26, 2016

dillaman Feb 26, 2016

Choose a reason for hiding this comment

dillaman commented Feb 26, 2016

jdurgin commented Mar 2, 2016

dillaman Mar 7, 2016

Choose a reason for hiding this comment

sahithi-rv commented Mar 10, 2016

dillaman commented Mar 10, 2016

dillaman commented Mar 11, 2016

dillaman Mar 11, 2016

Choose a reason for hiding this comment

sahithi-rv Mar 11, 2016

Choose a reason for hiding this comment

dillaman Mar 11, 2016

Choose a reason for hiding this comment

dillaman Mar 20, 2016

Choose a reason for hiding this comment

sahithi-rv commented Mar 22, 2016

dillaman commented Mar 22, 2016

dillaman commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

dillaman commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

sahithi-rv commented Mar 22, 2016

dillaman commented Mar 22, 2016

sahithi-rv commented Apr 3, 2016

sahithi-rv commented Apr 3, 2016

dillaman commented Apr 4, 2016

dillaman commented Jun 21, 2016