rgw: file setattr #8618
Merged
rgw: file setattr #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liewegas I'm updating this now, need to use a different path to update attrs |
| @@ -375,6 +375,7 @@ namespace librados | |||
| void zero(uint64_t off, uint64_t len); | |||
| void rmxattr(const char *name); | |||
| void setxattr(const char *name, const bufferlist& bl); | |||
| void setxattr(const char *name, const buffer::list&& bl); | |||
mattbenjamin
force-pushed
the
rgw-file-setattr
branch
3 times, most recently
from
c29fcc4
to
4de3be9
Compare
|
@oritwas I think this version should be ready to merge, can you revisit it? I have not replaced the quoted '/' and "/" with a constant in this change to avoid churn, I'll be happy to send a separate change to improve that. |
mattbenjamin
force-pushed
the
rgw-file-setattr
branch
from
4de3be9
to
f7ca7c8
Compare
Introduce a new RGWSetattrs RGWOp descendant, to create or replace sets of attrs on buckets or objects. This version of the change uses the standard RGWRADOS::set_attrs op (we want attribute changes to (e.g.) sync with other changes). Previous versions of this changed incorrectly masked the values of st->st_ino in RGWFileHandle::stat(), now fixed. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
rgw-file-setattr
branch
from
f7ca7c8
to
4de1c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posted for review only. The first 20 commits are already in a PR. The top commit "works" but may not replicate, among other potential problems.