test/ec: build the libs only when 'make check' #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we are always building the erasure code libraries while we need them only when 'make check' is run. Moving the test libraries to check_LTLIBRARIES should fix this for us. We no longer need to remove the libec libs manually, remove the lines that do that. Signed-off-by: Boris Ranto <branto@redhat.com>
ghost
merged commit 
|
Excellent! |
|
Making a note to slip this into one of the packaging backport PRs. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are always building the erasure code libraries while we
need them only when 'make check' is run. Moving the test libraries to
check_LTLIBRARIES should fix this for us.
We no longer need to remove the libec libs manually, remove the lines
that do that.
Signed-off-by: Boris Ranto branto@redhat.com