Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Encryption s3 sse kms #118

Closed
wants to merge 6 commits into from
Closed

Conversation

aclamk
Copy link

@aclamk aclamk commented Jul 11, 2016

This are codes that test features implemented by:
https://github.com/aclamk/ceph/tree/wip-rgw-s3-crypto-sse-kms
If above is not merged, most of tests will fail.

Adam Kupczyk added 2 commits June 2, 2016 18:19
All tests belong to group 'encryption'.

Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
All tests belong to group 'encryption'.

Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Adam Kupczyk added 4 commits September 16, 2016 17:37
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
…gration

Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some test failures now that HEAD requests require customer keys

eq(result.get('x-rgw-object-count', 1), 1)
eq(result.get('x-rgw-bytes-used', 30 * 1024 * 1024), 30 * 1024 * 1024)

k = bucket.get_key(key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-    k = bucket.get_key(key)
+    k = bucket.get_key(key, headers=put_headers)

'x-amz-server-side-encryption-customer-key-md5': 'DWygnHRtgiJ77HCm+1rvHw=='
}

key = bucket.get_key("foo.txt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-    key = bucket.get_key("foo.txt")
+    key = bucket.get_key("foo.txt", headers=get_headers)

eq(result.get('x-rgw-object-count', 1), 1)
eq(result.get('x-rgw-bytes-used', 30 * 1024 * 1024), 30 * 1024 * 1024)

k = bucket.get_key(key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-    k = bucket.get_key(key)
+    k = bucket.get_key(key, headers=put_headers)

@cbodley
Copy link
Contributor

cbodley commented Mar 1, 2017

i pushed a rebased version of this branch to https://github.com/ceph/s3-tests/commits/wip-pr-118 for teuthology. it includes a patch to fix the headers for those HEAD requests

@cbodley
Copy link
Contributor

cbodley commented Mar 10, 2017

@aclamk can you please rebase, and pull in my latest commit from https://github.com/ceph/s3-tests/commits/wip-pr-118 so we can merge this one?

@cbodley
Copy link
Contributor

cbodley commented Mar 28, 2017

merged in #154, thanks @aclamk!

@cbodley cbodley closed this Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants