-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: Encryption s3 sse kms #118
Conversation
All tests belong to group 'encryption'. Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
All tests belong to group 'encryption'. Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
…gration Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some test failures now that HEAD requests require customer keys
eq(result.get('x-rgw-object-count', 1), 1) | ||
eq(result.get('x-rgw-bytes-used', 30 * 1024 * 1024), 30 * 1024 * 1024) | ||
|
||
k = bucket.get_key(key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- k = bucket.get_key(key)
+ k = bucket.get_key(key, headers=put_headers)
'x-amz-server-side-encryption-customer-key-md5': 'DWygnHRtgiJ77HCm+1rvHw==' | ||
} | ||
|
||
key = bucket.get_key("foo.txt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- key = bucket.get_key("foo.txt")
+ key = bucket.get_key("foo.txt", headers=get_headers)
eq(result.get('x-rgw-object-count', 1), 1) | ||
eq(result.get('x-rgw-bytes-used', 30 * 1024 * 1024), 30 * 1024 * 1024) | ||
|
||
k = bucket.get_key(key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- k = bucket.get_key(key)
+ k = bucket.get_key(key, headers=put_headers)
i pushed a rebased version of this branch to https://github.com/ceph/s3-tests/commits/wip-pr-118 for teuthology. it includes a patch to fix the headers for those HEAD requests |
@aclamk can you please rebase, and pull in my latest commit from https://github.com/ceph/s3-tests/commits/wip-pr-118 so we can merge this one? |
This are codes that test features implemented by:
https://github.com/aclamk/ceph/tree/wip-rgw-s3-crypto-sse-kms
If above is not merged, most of tests will fail.