Test multipart copy part feature #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
|
👍 |
gaul
added a commit
to gaul/s3proxy
that referenced
this pull request
Sep 2, 2015
The previously used MD5 covered the entire object, not just the range request. Uncovered by ceph/s3-tests#75.
yehudasa
added a commit
that referenced
this pull request
Oct 27, 2015
Test multipart copy part feature Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
|
@yehudasa I will take care of the missing test case |
|
@robbat2 thanks for reporting, see ceph/ceph#5673 to details. The 'multipart copy part' feature did not ship with Jewel at the end. Those tests are part of the effort to support that feature. With the feature in place the -ERR_NOT_IMPLEMENTED code disappears and tests pass. As suggested, I think it could make sense adding the fails_on_rgw annotation (PR #99) on test_multipart_copy_small and test_multipart_copy_multiple_sizes while the feature is not ready. What do you think @yehudasa? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multipart uploads copy part feature tests.
See ceph/ceph#5673