Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTP endpoint - it works #2210

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

ukstv
Copy link
Contributor

@ukstv ukstv commented Jun 6, 2022

Add HTTP endpoint /collection.

No ordering options.

Few minor improvements à la housekeeping.

@ukstv ukstv requested review from PaulLeCam and stbrody June 6, 2022 12:16
@ukstv ukstv force-pushed the feature/net-1523-implement-http-endpoint-for-index branch from de5adb3 to c0e8fc1 Compare June 6, 2022 16:42
Copy link
Contributor

@stbrody stbrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with small suggestion to include context on previous error in newly thrown error

packages/cli/src/daemon/collection-query.ts Outdated Show resolved Hide resolved
Co-authored-by: Spencer T Brody <spencer+github@3box.io>
@oed oed assigned ukstv Jun 8, 2022
@ukstv ukstv merged commit 28bf9aa into develop Jun 8, 2022
@ukstv ukstv deleted the feature/net-1523-implement-http-endpoint-for-index branch June 8, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants