Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deserializer from cache backward compatible #70

Closed
niobos opened this issue Dec 4, 2022 · 0 comments
Closed

Make deserializer from cache backward compatible #70

niobos opened this issue Dec 4, 2022 · 0 comments

Comments

@niobos
Copy link
Collaborator

niobos commented Dec 4, 2022

The (de)serialization currently uses Pickle. This breaks when upgrading the classes of the stored objects, since the deserializer can't find the newly added fields in the file.

We need a backward compatible deserialization process. This probably means writing a (de)serializer explicitly instead of relying on pickle. (This has an added security advantage; unpickle-ing isn't very safe to do if the source is not trusted)

See also: #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants