Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show icons for applications and preferences on MacOS #42

Closed
lavir opened this issue Jan 27, 2017 · 7 comments
Closed

Show icons for applications and preferences on MacOS #42

lavir opened this issue Jan 27, 2017 · 7 comments

Comments

@lavir
Copy link
Contributor

lavir commented Jan 27, 2017

Cerebro does not display icons for applications and preferences on MacOS

Probably the reason is in that the apps in MacOS are folders. In the apps/index.js uses path for icon which is in this case is dir. Real icon is bit deeper AppName.app/Contents/Resources/*.icns

@Kageetai
Copy link
Contributor

Icons work perfectly fine for me. Can you add a screenshot or so to clarify?

@KELiON
Copy link
Collaborator

KELiON commented Jan 30, 2017

@lavir what icons do you mean? Can you attach a screenshot? For me preferences icons work well

screen shot 2017-01-30 at 10 56 31

@lavir
Copy link
Contributor Author

lavir commented Jan 30, 2017

The screenshot below
I would like notice that I launched Cerebro by npm run dev.
screen shot 2017-01-30 at 15 33 35

@KELiON
Copy link
Collaborator

KELiON commented Jan 30, 2017

@lavir and does it work when you launch precompiled .app file?

Also, I believe there is something broken for you in background process:

  1. Type settings and turn on developer mode, turn on "show in menu bar";
  2. Toggle Cerebro window and from tray menu select development → dev tools (background), switch to console tab;
  3. Reload everything (development → reload);
  4. Try to find 'mouse' and check if you have any errors in console;

@lavir
Copy link
Contributor Author

lavir commented Jan 31, 2017

.app works fine.

in dev mode no
in the background process didn't notice any problem (at least in Console) only this
bindings.js:83 Uncaught Error: Module version mismatch. Expected 50, got 48.

and in main process
localhost:3000/dist/main.bundle.js:3100 Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the Preload component.

in the terminal nothing interesting too.

@KELiON
Copy link
Collaborator

KELiON commented Jan 31, 2017

@lavir looks like in your dev environment native modules were built with wrong modules versions. Check item 2 here to fix your problem

@lavir
Copy link
Contributor Author

lavir commented Jan 31, 2017

Yes, this solved my problem.
Thank you!

@lavir lavir closed this as completed Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants