Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unsymmetric_linear_solver_test #279

Closed
sandwichmaker opened this issue May 4, 2017 · 1 comment
Closed

Refactor unsymmetric_linear_solver_test #279

sandwichmaker opened this issue May 4, 2017 · 1 comment

Comments

@sandwichmaker
Copy link
Contributor

  1. Value parameterized tests for smaller code.
  2. Break apart this file into individual test files, since the name itself is not terribly informative
  3. Larger collection of matrices with a more varied sparsity structure.
  4. The tests for dynamic_sparse_cholesky_solver don't really test the dynamic nature of the solve.
keir pushed a commit that referenced this issue Jun 8, 2017
@sandwichmaker
Refactor unsymmetric_linear_solver_test
efa0911 
1. Break up unsymmetric_linear_solver_test into
   a. dense_linear_solver_test which covers DENSE_QR and
      DENSE_NORMAL_CHOLESKY.
   b. sparse_normal_cholesky_solver_test which covers
      SPARSE_NORMAL_CHOLESKY.

2. dense_linear_solver_test has been completely re-written. It now
   uses value parameterized tests for better logging. The number of
   test problems as been increased to 2. Last but not the least
   the actual test of correctness is not based on a golden solution
   computed using another linear solver. We now compute the residual
   and ensure that it is small.

#279

Change-Id: I9546a43e8ae85c31b2096a99405e47da326755ee
@sandwichmaker
Copy link
Contributor Author

this test does not exist anymore.

mystorm16 pushed a commit to mystorm16/ceres-solver that referenced this issue May 21, 2024
@sandwichmaker
Refactor unsymmetric_linear_solver_test
d027fdd 
1. Break up unsymmetric_linear_solver_test into
   a. dense_linear_solver_test which covers DENSE_QR and
      DENSE_NORMAL_CHOLESKY.
   b. sparse_normal_cholesky_solver_test which covers
      SPARSE_NORMAL_CHOLESKY.

2. dense_linear_solver_test has been completely re-written. It now
   uses value parameterized tests for better logging. The number of
   test problems as been increased to 2. Last but not the least
   the actual test of correctness is not based on a golden solution
   computed using another linear solver. We now compute the residual
   and ensure that it is small.

ceres-solver/ceres-solver#279

Change-Id: I9546a43e8ae85c31b2096a99405e47da326755ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sandwichmaker