Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConditionedCostFunction does not allow duplicate cost function pointers. #422

Closed
csukuangfj opened this issue Sep 21, 2018 · 1 comment
Closed

ConditionedCostFunction does not allow duplicate cost function pointers. #422

csukuangfj opened this issue Sep 21, 2018 · 1 comment
Assignees
@sandwichmaker

Comments

@csukuangfj
Copy link
Contributor

csukuangfj commented Sep 21, 2018 •
edited

See the code

ceres-solver/internal/ceres/conditioned_cost_function.cc

Lines 70 to 72 in 72d8e1c

if (ownership_ == TAKE_OWNERSHIP) {
STLDeleteElements(&conditioners_);
} else {

ceres-solver/internal/ceres/stl_util.h

Lines 51 to 54 in 72d8e1c

while (begin != end) {
ForwardIterator temp = begin;
++begin;
delete *temp;

It causes runtime errors when

ceres-solver/include/ceres/conditioned_cost_function.h

Line 91 in 72d8e1c

std::vector<CostFunction*> conditioners_;

contains duplicate pointers since they are freed multiple times.
@sandwichmaker sandwichmaker self-assigned this Sep 21, 2018
@sandwichmaker
Copy link
Contributor

https://ceres-solver-review.googlesource.com/c/ceres-solver/+/14340

keir pushed a commit that referenced this issue Sep 25, 2018
@sandwichmaker
Make ConditionedCostFunction compatible with repeated CostFunction.
c65cdd7 
If the user uses the same conditioner twice, it does not lead
to a double free errors.

#422

Change-Id: I9041ddcbffa8dcb882a63bddb82b384897efc970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandwichmaker sandwichmaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandwichmaker @csukuangfj