Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvaluationCallback and CreateReducedProgram do not interact correctly #482

Closed
sandwichmaker opened this issue Jun 6, 2019 · 0 comments
Closed

EvaluationCallback and CreateReducedProgram do not interact correctly #482

sandwichmaker opened this issue Jun 6, 2019 · 0 comments
Assignees
@sandwichmaker
Labels
bug
Milestone
2.0

Comments

@sandwichmaker
Copy link
Contributor

When removing constant residual blocks from a program as part of the preprocesser, we evaluate the "fixed" part of the cost of the problem, and this requires calling ResidualBlock::Evaluate. This works fine if no EvaluationCallback is associated with the problem. But if one is, then for correctness it needs to be called before Evaluate is called.
@sandwichmaker sandwichmaker self-assigned this Jun 6, 2019
@sandwichmaker sandwichmaker added this to the 2.0 milestone Jun 6, 2019
keir pushed a commit that referenced this issue May 28, 2020
@sandwichmaker
Call EvaluationCallback before evaluating the fixed cost.
a614f78 
Fixe a subtle bug in Program::RemoveFixedBlocks, where we call
ResidualBlock::Evaluate on residual blocks with all constant parameter
blocks without paying attention to the presence of an
EvaluationCallback.

In the process also run clang-format on some of the files touched by
this change.

#482

Change-Id: I342b66f6f975fdee2eef139a31f24d4a3e568e84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandwichmaker sandwichmaker

Labels
bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@sandwichmaker