Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is functor not available for DynamicAutoDiffCostFunction but is for AutoDiffCostFunction? #962

Closed
nmerrill67 opened this issue Mar 31, 2023 · 1 comment
Assignees
Milestone

Comments

@nmerrill67
Copy link

Hello. I have a particular use case where I am doing a multi-step optimization, and would like to edit some members of the cost functor of DynamicAutoDiffCostFunction's CostFunctor, but the member is private. I noticed however that a reference is available for AutoDiffCostFunction

const CostFunctor& functor() const { return *functor_; }

I am wondering if there is a reason it's not available for DynamicAutoDiffCostFunction? It would be useful and a very quick PR to add it. I have been creating the cost function outside of the CostFunctor class (i.e., outside of the useful Create function) which works but is not so concise, so I am wondering if there is any reasoning behind this discrepancy. Thanks.

@sandwichmaker
Copy link
Contributor

This is likely just an oversight. Please send me a change on Gerrit following http://www.ceres-solver.org/contributing.html I would happily approve it.

@sandwichmaker sandwichmaker self-assigned this Aug 8, 2023
@sandwichmaker sandwichmaker added this to the 2.2 milestone Aug 8, 2023
keir pushed a commit that referenced this issue Sep 25, 2023
#962

Change-Id: I50c327eb7ac09a894582ee3fb3311825607640c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants