This repository has been archived by the owner on May 24, 2024. It is now read-only.
Lock react 15.4.2 #202
Merged
Lock react 15.4.2 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Butler
commented
Apr 10, 2017
| @@ -28,8 +28,7 @@ | |||
| "react-dom": "^15.4.2" | |||
| }, | |||
| "dependencies": { | |||
| "classnames": "^2.2.5", | |||
| "react": "^15.4.2" | |||
There was a problem hiding this comment.
I am removing react as a dependency for several of our packages. I am noticing this is forcing multiple nested versions of react to be installed.
There was a problem hiding this comment.
I have some reservations about removing react as a dependency. Let's talk this some more tomorrow
There was a problem hiding this comment.
Here is the issue I am seeing:
- lock react at 15.4.2 in the root directory and in terra-site.
npm run clean:install- Inspect node_modules in any package that has a dependency on react. You will see a react directory with react 15.5.x. This gets confusing quickly because I am unsure which version of react each of these packages is using during testing / runtime.
We can discuss more tomorrow.
There was a problem hiding this comment.
This is also the same approach cloudflare-ui is taking: https://github.com/cloudflare/cf-ui/blob/master/packages/cf-component-callout/package.json#L14
mjhenkes
approved these changes
Apr 10, 2017
|
+1 |
StephenEsser
approved these changes
Apr 11, 2017
bjankord
approved these changes
Apr 11, 2017
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The upgrade to React 15.5 is non-passive. I am locking react down at 15.4.2 until we update our packages to be compatible with 15.5.
@cerner/terra