-
Notifications
You must be signed in to change notification settings - Fork 167
Conversation
@@ -28,8 +28,7 @@ | |||
"react-dom": "^15.4.2" | |||
}, | |||
"dependencies": { | |||
"classnames": "^2.2.5", | |||
"react": "^15.4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am removing react
as a dependency for several of our packages. I am noticing this is forcing multiple nested versions of react
to be installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some reservations about removing react as a dependency. Let's talk this some more tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the issue I am seeing:
- lock react at 15.4.2 in the root directory and in terra-site.
npm run clean:install
- Inspect node_modules in any package that has a dependency on react. You will see a react directory with react 15.5.x. This gets confusing quickly because I am unsure which version of react each of these packages is using during testing / runtime.
We can discuss more tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also the same approach cloudflare-ui is taking: https://github.com/cloudflare/cf-ui/blob/master/packages/cf-component-callout/package.json#L14
+1 |
+1 |
Summary
The upgrade to React 15.5 is non-passive. I am locking react down at 15.4.2 until we update our packages to be compatible with 15.5.
@cerner/terra