Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Lock react 15.4.2 #202

Merged
merged 13 commits into from
Apr 11, 2017
Merged

Lock react 15.4.2 #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
841ea6a
0.2.0
Matt-Butler Mar 27, 2017
6b27f00
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Mar 28, 2017
f4afc9a
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Mar 30, 2017
cadad47
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Mar 30, 2017
55d9b08
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Mar 30, 2017
8c725d8
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Mar 30, 2017
9f949ff
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Mar 30, 2017
dfcf85f
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Apr 3, 2017
8ebb8a4
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Apr 4, 2017
60fbe10
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Apr 6, 2017
178653e
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Apr 7, 2017
0e17fc2
Merge branch 'master' of github.com:cerner/terra-core
Matt-Butler Apr 10, 2017
c1580a1
lock react at 15.4.2
Matt-Butler Apr 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@
"jest": "^18.1.0",
"lerna": "2.0.0-beta.36",
"load-json-file": "^2.0.0",
"react": "^15.4.2",
"react-addons-test-utils": "^15.4.2",
"react-dom": "^15.4.2",
"react": "15.4.2",
"react-addons-test-utils": "15.4.2",
"react-dom": "15.4.2",
"react-router": "^3.0.2",
"shelljs": "^0.7.6",
"stylelint": "^7.8.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/terra-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"react-dom": "^15.4.2"
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am removing react as a dependency for several of our packages. I am noticing this is forcing multiple nested versions of react to be installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some reservations about removing react as a dependency. Let's talk this some more tomorrow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the issue I am seeing:

  1. lock react at 15.4.2 in the root directory and in terra-site.
  2. npm run clean:install
  3. Inspect node_modules in any package that has a dependency on react. You will see a react directory with react 15.5.x. This gets confusing quickly because I am unsure which version of react each of these packages is using during testing / runtime.

We can discuss more tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also the same approach cloudflare-ui is taking: https://github.com/cloudflare/cf-ui/blob/master/packages/cf-component-callout/package.json#L14

"classnames": "^2.2.5"
},
"scripts": {
"compile": "npm run compile:clean && npm run compile:build",
Expand Down
1 change: 0 additions & 1 deletion packages/terra-clinical-item-view/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-icon": "^0.x",
"terra-mixins": "^1.0.0"
},
Expand Down
1 change: 0 additions & 1 deletion packages/terra-content/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-mixins": "^1.0.0"
},
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion packages/terra-detail-view/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-mixins": "^1.0.0"
},
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion packages/terra-icon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-mixins": "^1.0.0"
},
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion packages/terra-list/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-icon": "^0.x",
"terra-mixins": "^1.0.0"
},
Expand Down
1 change: 0 additions & 1 deletion packages/terra-responsive-element/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"terra-mixins": "^1.0.0"
},
"dependencies": {
"react": "^15.4.2",
"resize-observer-polyfill": "^1.4.1",
"terra-mixins": "^1.0.0"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/terra-site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"test:spec": "echo \"Warning: no test written\" && exit 0"
},
"dependencies": {
"react": "^15.4.2",
"react-dom": "^15.4.2",
"react": "15.4.2",
"react-dom": "15.4.2",
"react-intl": "^2.2.3",
"react-router": "^3.0.2",
"terra-arrange": "^0.x",
Expand Down
1 change: 0 additions & 1 deletion packages/terra-slide-panel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-mixins": "^1.0.0"
},
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion packages/terra-table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
},
"dependencies": {
"classnames": "^2.2.5",
"react": "^15.4.2",
"terra-icon": "^0.x",
"terra-mixins": "^1.0.0"
},
Expand Down