Added download attribute check for IE11 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhemesath
reviewed
Mar 27, 2018
src/provider/application.js
Outdated
| @@ -260,6 +260,9 @@ class Application extends EventEmitter { | |||
| } | |||
|
|
|||
| unload() { | |||
| if (document.activeElement && document.activeElement.hasAttribute('download')) { | |||
There was a problem hiding this comment.
put a comment as to why you are doing this
|
Please add a note in release notes |
gauthamsriman
approved these changes
Mar 27, 2018
slor
approved these changes
Mar 27, 2018
divyaashritha
approved these changes
Mar 27, 2018
|
code change looks good to me. waiting for release notes |
slor
approved these changes
Mar 27, 2018
|
I confirmed with @mhemesath offline that this code is +1. OK to close review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix checks for a download attribute in the onbeforeunload listener so that downloads aren't confused with redirects in IE11
Additional Details
The download attribute on a link tag typically lets the browser know that the link is a download instead of a redirect and therefore skips firing the onbeforeunload listener. However, the download attribute is not supported in IE11. a workaround is to look specifically look for the download attribute and return if it is found.