Adding babel-runtime and transform plugins #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhemesath
reviewed
Oct 13, 2017
| @@ -13,6 +13,7 @@ | |||
| } | |||
| html[hidden] { display: none; } | |||
| </style> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/babel-polyfill/6.23.0/polyfill.min.js"></script> | |||
There was a problem hiding this comment.
Why are you adding the poly fill here if it isn’t needed
There was a problem hiding this comment.
actually polyfill is needed on this page, however, it's not used for XFC but for an explicit Promise call on this page. We call Promise.resolve in secret function. See here
mhemesath
approved these changes
Oct 13, 2017
kafkahw
commented
Oct 13, 2017
| @@ -10,6 +10,7 @@ | |||
| html[hidden] { display: none; } | |||
| </style> | |||
| <script src="http://localhost:8080/xfc.js"></script> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/babel-polyfill/6.23.0/polyfill.min.js"></script> | |||
There was a problem hiding this comment.
same here, the polyfill here is not used for xfc, but for a Promise call on this page.
|
Did you test this in IE10 for @poloka |
|
yes, just ran through all existing examples in IE10 and everything looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added babel-runtime and a couple transform plugins that remove the need of extra global polyfills.
Additional Details
This won't pollute global so the consumer of xfc can still choose to include a global polyfill if they want. However, extra polyfills are not needed to consume this library.
Thanks for contributing to xfc.