Custom dispatch function #75
Conversation
src/provider/application.js
Outdated
| @@ -240,14 +249,17 @@ class Application extends EventEmitter { | |||
|
|
|||
| if (message) { | |||
| logger.log('>> provider', this.acls, message); | |||
|
|
|||
| const dispatch = this.dispatchFunction || parent.postMessage; | |||
There was a problem hiding this comment.
move this logic into the init block. It should also contain the logic to skip messages when not embedded rather than coupling that logic to custom dispatch methods.
this.dispatchFunction = dispatchFunction || (message, targetOrigin) => {
if (window.self !== window.top) {
parent.postMessage(message, targetOrigin);
}
});
``There was a problem hiding this comment.
Moved: 7968afd
| @@ -20,15 +20,24 @@ class Application extends EventEmitter { | |||
| * a SyntaxError exception is thrown. | |||
| * @param options.options An optional object used for App to transmit details to frame | |||
| * after App is authorized. | |||
| * @param options.dispatchFunction A function that will be used to dispatch messages instead of | |||
There was a problem hiding this comment.
document the expected method signature
src/provider/application.js
Outdated
| // Dont' send messages if not embedded | ||
| if (window.self === window.top) { | ||
| // Don't send messages if not embedded, unless a custom dispatch function was provided | ||
| if (!this.dispatchFunction && window.self === window.top) { |
There was a problem hiding this comment.
skipping message sending should be an implementation detail of the dispatcher as I indicate below
| @@ -40,7 +40,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.3.1", | |||
There was a problem hiding this comment.
A bit of an aside here, we have this version of XFC: https://github.com/cerner/xfc/pull/58/files which we have delayed integrating into our systems because of IE11's lack of includes() support.
@mhemesath do you forsee this still being an issue? Should we do work to patch that?
There was a problem hiding this comment.
That pull request didn't introduce includes? I think we should drop support for IE11.
src/provider/application.js
Outdated
| @@ -167,8 +192,7 @@ class Application extends EventEmitter { | |||
| */ | |||
| launch() { | |||
| if (window.self !== window.top) { | |||
| // 1: Setup listeners for all incoming communication and beforeunload | |||
| window.addEventListener('message', this.handleConsumerMessage); | |||
| // 1: Setup listener for beforeunload | |||
| window.addEventListener('beforeunload', this.unload); | |||
There was a problem hiding this comment.
i'd probably move this out to initialize too
There was a problem hiding this comment.
Moved: dab024f
Summary
Adds a
dispatchFunctionoption toProvider.init.Additional Details
For usage outside the context of iframes (e.g. a web app running in a webview), allows specifying a function to use to send messages to the Consumer instead of
parent.postMessage.