Allow replicaCount to be set to int or string

[wallrj]

This allows @erikgb to continue to use a variable string for the replicaCount field.

I added a helm-tool type tag to the replicaCount value of number,string,null, which has the effect of removing the type from the generated Helm JSON schema.
Probably because helm-tool doesn't recognise the type value.

As discussed on Slack .

$ helm template deploy/charts/approver-policy/ | grep replicas
  replicas: 1

$ helm template deploy/charts/approver-policy/ --set replicaCount=2 | grep replicas
  replicas: 2

$ helm template deploy/charts/approver-policy/ --set replicaCount='${REPLICAS_OVERRIDE:=3}' | grep replicas
  replicas: ${REPLICAS_OVERRIDE:=3}

$ helm template deploy/charts/approver-policy/ --set replicaCount=null | grep replicas
  replicas:

[erikgb]

/lgtm

Very nice, @wallrj! Thanks a lot! Are you able to cut a new alpha release so I can verify it solves my issue, or is that too much work? Maybe we should be optimistic and head for a release - with an eventual bugfix if it doesn't work?

[wallrj]

[wallrj]

Very nice, @wallrj! Thanks a lot! Are you able to cut a new alpha release so I can verify it solves my issue, or is that too much work? Maybe we should be optimistic and head for a release - with an eventual bugfix if it doesn't work?

Thanks @erikgb. Yes I will do another alpha for you to test this before we release 0.13

[inteon]

/retest

[inteon]

/approve
/lgtm
We might make this field type more strict in the future.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wallrj]

@erikgb Here's another alpha release, as promised:

• https://github.com/cert-manager/approver-policy/releases/tag/v0.13.0-alpha.1
• https://charts.jetstack.io/index.yaml

Please test it if you have time.

[erikgb]

Please test it if you have time.

@wallrj I have verified it works now. Thanks for fixing this issue!