-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow replicaCount to be set to int or string #388
Conversation
/lgtm Very nice, @wallrj! Thanks a lot! Are you able to cut a new alpha release so I can verify it solves my issue, or is that too much work? Maybe we should be optimistic and head for a release - with an eventual bugfix if it doesn't work? |
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erikgb. Yes I will do another alpha for you to test this before we release 0.13 |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@erikgb Here's another alpha release, as promised:
Please test it if you have time. |
@wallrj I have verified it works now. Thanks for fixing this issue! |
This allows @erikgb to continue to use a variable string for the replicaCount field.
I added a helm-tool type tag to the
replicaCount
value ofnumber,string,null
, which has the effect of removing the type from the generated Helm JSON schema.Probably because helm-tool doesn't recognise the type value.
As discussed on Slack .
$ helm template deploy/charts/approver-policy/ | grep replicas replicas: 1
$ helm template deploy/charts/approver-policy/ --set replicaCount=2 | grep replicas replicas: 2
$ helm template deploy/charts/approver-policy/ --set replicaCount=null | grep replicas replicas: