Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to specify key usage #18

Closed
jdef opened this issue Feb 24, 2020 · 1 comment · Fixed by #19
Closed

how to specify key usage #18

jdef opened this issue Feb 24, 2020 · 1 comment · Fixed by #19
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jdef
Copy link

jdef commented Feb 24, 2020

https://github.com/jetstack/cert-manager-csi/blob/3bca455847427c2ac623946164518bb49beb37dd/pkg/certmanager/certmanager.go#L182

According to the above, it looks like there's no way to specify key usage. The docs indicate that when KeyUsage is not specified for a CSR then the default is (digital-signature, key-encipherment).

At first glance this appears rather limiting: if I need a TLS cert w/ client-auth, or server-auth then there's no way specify that via this API.
@JoshVanL
Copy link
Contributor

Hi @jdef :)

Indeed, this is just not implemented yet.

@JoshVanL JoshVanL added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Feb 25, 2020
@JoshVanL JoshVanL mentioned this issue Mar 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds csi.cert-manager.io/key-usages attribute JoshVanL/csi-driver
2 participants
@jdef @JoshVanL