Document the ingressClassName field
#1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maël Valais <mael@vls.dev>
They should be "name" and "class". Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
jetstack-bot
added
dco-signoff: no
jetstack-bot
added
size/L
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
wallrj
requested changes
Mar 10, 2023
| ### `class` | ||
| ### `ingressClassName` | ||
|
|
||
| > The field `ingressClassName` was added in cert-manager 1.12. |
There was a problem hiding this comment.
Is there an icon we use for these version info boxes?
There was a problem hiding this comment.
I did not find an existing icon. I added "ℹ️" and an info div.
Note that usually, we use the format:
FEATURE STATE: cert-manager 1.12 [GA]
This format doesn't let the user know when the feature was first introduced (can they use the feature, even if in alpha?).
content/docs/installation/upgrading/ingress-class-compatibility.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev> Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
maelvls
force-pushed
the
ingressclassname
branch
from
66b8655
to
0b99aa0
Compare
|
I addressed your comments. PTAL @wallrj |
wallrj
approved these changes
Mar 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation PR: cert-manager/cert-manager#5849