Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 1.12] Merge release-next into master #1231

Merged
merged 36 commits into from May 23, 2023
Merged

[Release 1.12] Merge release-next into master #1231

merged 36 commits into from May 23, 2023

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented May 23, 2023 •
edited

The order for merging the PRs is listed in #1227.

/override dco

jetstack-bot and others added 30 commits February 21, 2023 08:15
@jetstack-bot
Merge pull request cert-manager#1189 from cert-manager/master
0b5d7e2 
[release-next] Fast-forward to master
@maelvls
vault: document the new field "serviceAccountRef"
1d838a8 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
serviceAccountRef: address Richard's comments
ab117a7 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls @wallrj
serviceAccoutRef: PR review suggestions
803891f 
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls @wallrj
serviceAccoutRef: PR review suggestions
46cdf9c 
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
serviceAccountRef: add a release-note page for v1.12
dcef301 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
package.json: use "npm exec" for running the "concurrently" tool
c399aae 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
fix dead link
fe91700 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
Revert "package.json: use "npm exec" for running the "concurrently" t…
32a3e8b 
…ool"

This reverts commit c399aae.

I mistakenly forgot to run "npm i" before running ./scripts/verify.

Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot
Merge pull request cert-manager#1081 from maelvls/document-vault-boun…
d3c9fc6 
…d-serviceaccount

Vault: document the new field "serviceAccountRef"
@maelvls
ingressClassName: swap the "class" for the "ingressClassName"
09fd33b 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
guide: fix incorrect fields "ingress" and "ingressClass"
66cd7eb 
They should be "name" and "class".

Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
update the http01 does with ingressClassName
a1dfb91 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
add a mention in the release notes
aa00c3c 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
ingressClassName: update the API reference documentation
ef98aec 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
ingressClassName: re-add the ingress-class-compatibility page
2b69ad6 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls @wallrj
ingressClassName: add div and icon
ab1b9da 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
@maelvls @wallrj
ingressClassName: consistent warning using quote block
33bdb94 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
@maelvls @wallrj
ingressClassName: address PR comments
4de800f 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
@maelvls @wallrj
ingressClassName: move the warning to below the sections
0b99aa0 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-Authored-By: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot
Merge pull request cert-manager#1196 from maelvls/ingressclassname
0bb1720 
Document the `ingressClassName` field
@maelvls
write the release notes for 1.12
2e2a425 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
release-notes: add the latest changes to the release notes for 1.12
f69c9da 
Signed-off-by: Maël Valais <mael@vls.dev>
@irbekrm
Add a release note for memory improvements
9fe0b57 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@maelvls
release-notes-1.12: talk about the go.mod changes
ed440d3 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
use the official typography for VCert (instead of vCert)
6ca15f0 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
turn commit-like release notes into release notes
444b74f 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls @SgtCoDFish
rephrase the section about CVEs and Go modules
f75ba88 
Co-Authored-By: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
edit more release notes to make them user-friendly
68ba755 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls @SgtCoDFish
release-notes-1.12: address feedback
26aa94d 
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
Signed-off-by: Maël Valais <mael@vls.dev>
maelvls and others added 6 commits May 19, 2023 15:04
@maelvls
release-notes: add links to documentation, PRs and designs
2879046 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
release-notes: transform PR numbers and GitHub handles into links
df01bd8 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
release-notes: copy the "thank you" section from the GitHub release
e43ed15 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls
release-notes: fix spelling
5835a2e 
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot
Merge pull request cert-manager#1220 from maelvls/release-notes-1.12
efd9872 
Release notes for 1.12
@maelvls
Merge release-next into master
fe8bd0f 
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label May 23, 2023
@jetstack-bot
Copy link
Contributor

@maelvls: Overrode contexts on behalf of maelvls: dco

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@maelvls maelvls changed the title [Post-Release] Merge release-next into master #1230 [Post-Release] Merge release-next into master May 23, 2023
@jetstack-bot jetstack-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 23, 2023
@maelvls maelvls mentioned this pull request May 23, 2023
Merged
3 tasks
@netlify
Copy link

netlify bot commented May 23, 2023

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit fe8bd0f
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/646c9e600a215c000875dfa4
😎 Deploy Preview https://deploy-preview-1231--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

irbekrm
irbekrm approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for working on this 👍🏼

I did think that this PR will contain all the user-facing changes for 1.12 at the moment we still have 1.11 documented as the release to be installed, see https://deploy-preview-1231--cert-manager-website.netlify.app/docs/installation/supported-releases/

Happy to merge this as is and then merge a follow-up PR that updates the rest or if you want to update this PR that's good - feel free to unhold 👍🏼

/hold
/lgtm
/approve

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@maelvls
Copy link
Member Author

maelvls commented May 23, 2023

/override dco

@jetstack-bot
Copy link
Contributor

@maelvls: Overrode contexts on behalf of maelvls: dco

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maelvls maelvls changed the title [Post-Release] Merge release-next into master [Post-Release 1.12] Merge release-next into master May 23, 2023
@maelvls maelvls changed the title [Post-Release 1.12] Merge release-next into master [Release 1.12] Merge release-next into master May 23, 2023
@maelvls maelvls added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 23, 2023
irbekrm
irbekrm approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maelvls maelvls removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@jetstack-bot jetstack-bot merged commit df8d4d6 into cert-manager:master May 23, 2023
3 of 4 checks passed
@jetstack-bot jetstack-bot mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irbekrm irbekrm irbekrm approved these changes

Assignees

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maelvls @jetstack-bot @irbekrm