Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept IOBase stream as local resource input #29

Closed
psrok1 opened this issue Dec 8, 2020 · 0 comments · Fixed by #187
Closed

Accept IOBase stream as local resource input #29

psrok1 opened this issue Dec 8, 2020 · 0 comments · Fixed by #187
Labels
improvement New feature or request
Milestone
5.0.0

Comments

@psrok1
Copy link
Member

psrok1 commented Dec 8, 2020 •
edited
Loading

In addition to buffer and path, we should accept stream as well. The only issue is size that must be provided by user in that case.

Such a stream will be still owned by caller (Resource.upload doesn't close the stream)
nazywam pushed a commit that referenced this issue Dec 21, 2020
@psrok1
Merge branch 'feature/configurable-logging' into 'master'
0c30a84 
Allow karton log level to be configured with config

Closes #29

See merge request karton/karton!45
@psrok1 psrok1 added improvement New feature or request and removed enhancement labels Jul 15, 2022
@psrok1 psrok1 mentioned this issue Jul 20, 2022
Merged
@psrok1 psrok1 added this to the 5.0.0 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement New feature or request
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix handling on LocalResource with file descriptor as a source CERT-Polska/karton
1 participant
@psrok1