Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning on Python 3.11 #199

Merged
merged 4 commits into from Jul 15, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 15, 2022

Fixes #192.

Replaces and closes #193.

This is @adamchainz' PR #193 with @AA-Turner's suggestions applied, plus adding a missing where for 3.6 which is the same as the 3.7-3.8 block.

Also bump GitHub Actions versions.

Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@alex alex merged commit 47fb7ab into certifi:master Jul 15, 2022
7 checks passed
@hugovk hugovk deleted the issue_192_python3.6 branch July 15, 2022 13:33
webknjaz added a commit to aio-libs/aiohttp that referenced this pull request Aug 3, 2022
webknjaz added a commit to aio-libs/aiohttp that referenced this pull request Aug 3, 2022
webknjaz added a commit to aio-libs/aiohttp that referenced this pull request Aug 3, 2022
@adamchainz
Copy link
Contributor

Thank you for picking this up !

@QuLogic
Copy link

QuLogic commented Sep 8, 2022

Since 3.11 is now ABI stable, the ecosystem is starting to build/test against it. Any plans for a release here so we don't have to put in warning ignores everywhere?

@Lukasa
Copy link
Member

Lukasa commented Sep 9, 2022

New release was just pushed, 2022.06.15.1.

tsibley added a commit to tsibley/python-certifi that referenced this pull request Sep 13, 2022
…n ≥3.11

Using importlib.resource's files() API on 3.9 and 3.10 causes a
TypeError on 3.9 and a ValueError on 3.10 when running under a
third-party meta path importer (like PyOxidizer's OxidizedImporter) that
doesn't support the relatively-new API.  This is because the full
adapter layer (importlib.resources._adapters) for the older importlib
resources API doesn't exist until Python 3.11.

The older resources API is now used by 3.7–3.10, as it was prior to the
certifi 2022.06.15.1 release.  This codepath has existed in certifi
since April 2020 (3fc8fec).

An alternative to this change would be testing the actual importer in
use at runtime (e.g. certifi.__loader__) for files() support, but that
seemed more complex than reverting to the previous codepath here.

Resolves: certifi#203
Related-to: certifi#199
Related-to: certifi#123
Lukasa pushed a commit that referenced this pull request Sep 13, 2022
…n ≥3.11 (#204)

Using importlib.resource's files() API on 3.9 and 3.10 causes a
TypeError on 3.9 and a ValueError on 3.10 when running under a
third-party meta path importer (like PyOxidizer's OxidizedImporter) that
doesn't support the relatively-new API.  This is because the full
adapter layer (importlib.resources._adapters) for the older importlib
resources API doesn't exist until Python 3.11.

The older resources API is now used by 3.7–3.10, as it was prior to the
certifi 2022.06.15.1 release.  This codepath has existed in certifi
since April 2020 (3fc8fec).

An alternative to this change would be testing the actual importer in
use at runtime (e.g. certifi.__loader__) for files() support, but that
seemed more complex than reverting to the previous codepath here.

Resolves: #203
Related-to: #199
Related-to: #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning from importlib.resources on Python 3.11
5 participants