redis pipeline: brpoplpush is deprecated

[ghost]

BRPOPLPUSH is deprecated in favour of BLMOVE.

The command is used here:

intelmq/intelmq/lib/pipeline.py

Lines 271 to 272 in 979af96

	retval = self.pipe.brpoplpush(self.source_queue,
	self.internal_queue, 0)

and mocked here:

intelmq/intelmq/lib/bot_debugger.py

Line 120 in 188609b

pl.pipe.brpoplpush = lambda source_q, inter_q, i: pl.pipe.lindex(source_q, -1)

[aaronkaplan]

you could also take a look at redis streams

[ghost]

Do redis streams already support atomic push+pop operations? If not, we can add them as optional broker, if consistency is not important, but not as replacement for the redis-list based approach.

[aaronkaplan]

On 10.09.2021, at 15:56, Wagner ***@***.***> wrote: Do redis streams already support atomic push+pop operations?

yes AFAIK

If not, we can add them as optional broker, if consistency is not important, but not as replacement for the redis-list based approach.

Take a look and read the docs, it's pretty amazing what it can do.

…

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[waldbauer-certat]

I tried fixing that issue, but I've seen that redis-py had some bugs <= 4.1.2 with blmove, its fixed in the latest release redis/redis-py#1776. https://github.com/redis/redis-py/releases/tag/v4.1.2

Btw. I like their release design :D looks sooo pretty