Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use redis BLMOVE instead of BRPOPLPUSH (deprecated) #2149

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

waldbauer-certat
Copy link
Contributor

As BRPOPLPUSH has been marked as deprecated in favor of BLMOVE.

Fixes #1827

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #2149 (114cf81) into develop (8d1c926) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 114cf81 differs from pull request most recent head 8c8702b. Consider uploading reports for the commit 8c8702b to get more accurate results

@@             Coverage Diff             @@
##           develop    #2149      +/-   ##
===========================================
- Coverage    76.34%   76.30%   -0.05%     
===========================================
  Files          441      441              
  Lines        23652    23649       -3     
  Branches      3739     3739              
===========================================
- Hits         18058    18046      -12     
- Misses        4857     4864       +7     
- Partials       737      739       +2     
Impacted Files Coverage Δ
intelmq/lib/pipeline.py 64.70% <100.00%> (ø)
intelmq/bots/experts/reverse_dns/expert.py 83.87% <0.00%> (-11.30%) ⬇️
intelmq/bots/experts/threshold/expert.py 82.85% <0.00%> (-1.36%) ⬇️
intelmq/bin/intelmqctl.py 9.18% <0.00%> (-0.14%) ⬇️
intelmq/bin/intelmqsetup.py 0.00% <0.00%> (ø)
...elmq/tests/bots/experts/reverse_dns/test_expert.py 100.00% <0.00%> (ø)
intelmq/bots/experts/asn_lookup/expert.py 35.20% <0.00%> (+0.52%) ⬆️
...telmq/bots/experts/recordedfuture_iprisk/expert.py 42.55% <0.00%> (+0.61%) ⬆️
intelmq/bots/experts/maxmind_geoip/expert.py 21.42% <0.00%> (+0.62%) ⬆️
intelmq/bots/experts/tor_nodes/expert.py 47.05% <0.00%> (+0.63%) ⬆️
... and 1 more

Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLMOVE is

Available since: 6.2.0

Source: https://redis.io/commands/blmove/

For example, Debian Bullseye (11) has version 6.0. Just switching to BLMOVE will cause massive turbulences for the users, requiring them to switch to rolling release distros, PPA et. al. or compiling redis themselves.

I propose to support redis < 6.2.0 too.

Fixes #1827

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
@sebix sebix added this to the 3.1.0 milestone Jul 25, 2022
@sebix sebix self-assigned this Jul 25, 2022
@sebix sebix merged commit 60b2f07 into develop Jul 25, 2022
@sebix sebix deleted the enh-1827 branch July 25, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis pipeline: brpoplpush is deprecated
3 participants