Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race condition in filecollector line 75 #2128

Closed
aaronkaplan opened this issue Nov 30, 2021 · 2 comments · Fixed by #2147
Closed

race condition in filecollector line 75 #2128

aaronkaplan opened this issue Nov 30, 2021 · 2 comments · Fixed by #2147
Labels
bug Indicates an unexpected problem or unintended behavior component: bots invalid: duplicate Indicates similar issues or pull requests

Comments

@aaronkaplan
Copy link
Member

intelmq/intelmq/bots/collectors/file/collector_file.py

Line 75 in 74c5a64

with open(filename, 'rb') as fh:

Has a race condition. Two bots may open the same file twice , this would then result in duplicated reports . Bug.
@aaronkaplan aaronkaplan added the bug Indicates an unexpected problem or unintended behavior label Nov 30, 2021
@sebix
Copy link
Member

sebix commented Nov 30, 2021

possible duplicate of #1631

waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
1f40b23 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
@waldbauer-certat waldbauer-certat mentioned this issue Feb 1, 2022
Merged
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
74ecf6e 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
ecb99ac 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
7a518ea 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
@sebix
Copy link
Member

sebix commented Feb 2, 2022

Duplicate of #1631

@sebix sebix marked this as a duplicate of #1631 Feb 2, 2022
@sebix sebix closed this as completed Feb 2, 2022
@sebix sebix added the invalid: duplicate Indicates similar issues or pull requests label Feb 2, 2022
waldbauer-certat added a commit that referenced this issue Aug 3, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
39b57c4 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
sebix pushed a commit that referenced this issue Aug 8, 2022
@waldbauer-certat @wagner-intevation
FIX: Possible race condition in file collector
b1d1ded 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior component: bots invalid: duplicate Indicates similar issues or pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: Possible race condition in file collector certtools/intelmq
2 participants
@sebix @aaronkaplan