FIX: Possible race condition in file collector #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldbauer-certat
force-pushed
the
fix-1631
branch
3 times, most recently
from
ecb99ac
to
7a518ea
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2147 +/- ##
===========================================
+ Coverage 76.34% 76.36% +0.01%
===========================================
Files 441 441
Lines 23652 23668 +16
Branches 3739 3739
===========================================
+ Hits 18058 18074 +16
Misses 4857 4857
Partials 737 737
|
sebix
added
bug
wagner-intevation
suggested changes
Jul 25, 2022
There was a problem hiding this comment.
This commit does not fix #1631, the file output bot is missing. Please adapt the commit message.
waldbauer-certat
force-pushed
the
fix-1631
branch
from
7a518ea
to
39b57c4
Compare
Locking the file with python fcntl to aquire a file lock, it may not support windows installations :/ Fixes #2128 Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
|
Rebased on master to fix the merge conflict |
wagner-intevation
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/
Fixes #2128