Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential bug and a question #26

Closed
panditthecoder opened this issue Aug 8, 2018 · 1 comment
Closed

potential bug and a question #26

panditthecoder opened this issue Aug 8, 2018 · 1 comment

Comments

@panditthecoder
Copy link

panditthecoder commented Aug 8, 2018

Thanks for the code. found it helpful in understanding the complexities of stock price prediction.
line #208 in base.env.market.py

  if date_index < self.bound_index:
      # Get y, y is not at date index, but plus 1. (Training Set)
      instruments_y = scaled_frame.iloc[date_index + 1]['close']
  else:
       # Get y, y is at date index. (Test Set)
       instruments_y = scaled_frame.iloc[date_index + 1]['close']

both the if and else conditions have the same code. should the else statement be
instruments_y = scaled_frame.iloc[date_index]['close']

secondly, i had a question. how do i convert the scaled values back to the normal values after the predict function is called ? I would like to see the predicted price as a non scaled value ?
thanks and appreciate your effort.

@panditthecoder
Copy link
Author

ok. figured it out. it is not a bug. closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant