Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zip.js to 2.3.12 #9897

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Update zip.js to 2.3.12 #9897

merged 2 commits into from
Oct 27, 2021

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Oct 27, 2021

From the release notes of 2.3.12:

Fix issues when building zip.js with angular-cli 12.2.x and create-react-app

The issues stemmed from import.meta.url syntax requiring a separate loader for webpack 4. In webpack 5 this was not an issue. In testing this still works as expected, and the pako workers added in #9861 are still needed because of the Blob constructor errors on LTS node.js.

Thanks @puxiao for letting us know about the zip.js update!

@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ebogo1 ebogo1 requested a review from lilleyse October 27, 2021 20:27
@lilleyse lilleyse merged commit d395ac8 into main Oct 27, 2021
@lilleyse lilleyse deleted the update-zip.js branch October 27, 2021 20:50
@puxiao
Copy link
Contributor

puxiao commented Oct 28, 2021

I noticed that the latest version of zip.js is 2.3.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants