Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Release configuration #40

Closed
koudis opened this issue Jun 20, 2019 · 3 comments
Closed

Build with Release configuration #40

koudis opened this issue Jun 20, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@koudis
Copy link
Collaborator

koudis commented Jun 20, 2019

Hello all,

I use USBIP client on windows. It works quite fine (except some errors with queue overflow etc.).

I Try to compile USBIP by Release configuration. It fails. Mainly because mishmash between debug and release header/libraries.

My question is - is this behaviour intentionall ot it's a bug. If it's a Bug, may I create PR with repairs? Or it's the subject of further/actual development.

@cezuni In case of PR - from which branch I can create a PR?

@cezuni
Copy link

cezuni commented Jun 22, 2019

@koudis : Release configuration has not been a main concern. But you are welcome to improve it. master branch would be good for PR.

@koudis
Copy link
Collaborator Author

koudis commented Jun 23, 2019

ok, thanks for reply. If the Release configuration is not a main concern I will not create PR for this now (it just complicate development).

But I try to create PR with Toolset update. Just for "make all dependencies actual".

@Oxalin Oxalin added the enhancement New feature or request label Jul 3, 2019
@cezuni
Copy link

cezuni commented Jul 10, 2019

Current usbip-win is able to build with release configuration. (refer #42)

@cezuni cezuni closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants