Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change altz to z in :coordinates attribute #35

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

RussellSenior
Copy link
Contributor

coordinates attribute refers to an undefined variable altz, which doesn't exist as a variable or anything else, afaict, but z does.

@rhattersley
Copy link
Member

Thanks @RussellSenior 😄

I'd love to merge this fix, but we're going to have to hold off until we've finalised v1.6. (Then we can start applying the agreed changes for 1.7 and any other fixes.)

@rhattersley rhattersley added this to the 1.7 milestone Nov 18, 2015
@rhattersley
Copy link
Member

Hi @RussellSenior. This repo has now been officially adopted and moved to the cf-convention organisation. But the official process for changes to the conventions still requires going through the CF trac system. Once the change has been agreed there it can be applied via a PR here. Sorry if that seems a long-winded way of doing things but the CF community don't seem to be ready to switch to GitHub yet.

Would you be happy to create a ticket in the trac system for this change?

@JonathanGregory
Copy link
Contributor

Yes, this change needs a trac defect ticket. It looks like a mistake and fixing it would not be a change to the intention of the convention, but the point of a defect ticket is to give a chance for anyone to disagree with that. Defect tickets are agreed by default if no-one objects within three weeks. See http://cfconventions.org/errors.html. Thanks for noticing it. Jonathan

@dblodgett-usgs dblodgett-usgs added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Jun 22, 2019
@dblodgett-usgs
Copy link
Contributor

Now that we have hashed out github governance, this should just be merged as far as I'm concerned. Anyone disagree?

@marqh
Copy link
Member

marqh commented Jun 26, 2019

Now that we have hashed out github governance, this should just be merged as far as I'm concerned. Anyone disagree?

I agree

@dblodgett-usgs dblodgett-usgs merged commit d098344 into cf-convention:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants